From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 9/53] radeonfb: Clean up printk()'s in
Date: Mon, 21 Feb 2005 20:34:57 +0000 [thread overview]
Message-ID: <20050221203457.GA4174@nd47.coderock.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On 25/01/05 17:09 -0600, James Nelson wrote:
> @@ -28,6 +28,7 @@
> *
> */
>
> +#undef DEBUG
>
> #define RADEON_VERSION "0.1.6"
>
> @@ -80,12 +81,8 @@
> #include <video/radeon.h>
> #include <linux/radeonfb.h>
>
> -#define DEBUG 1
> -
> -#if DEBUG
> -#define RTRACE printk
> -#else
> -#define RTRACE if(0) printk
> +#ifdef DEBUG
> +#define RTRACE pr_debug
> #endif
>
> // XXX
This produced warning, on !DEBUG RTRACE wasn't defined. Fixed for -kj,
and also restored DEBUG behaviour which you turned off.
Domen
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-02-21 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-21 20:34 Domen Puncer [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-25 23:09 [KJ] [PATCH 9/53] radeonfb: Clean up printk()'s in James Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050221203457.GA4174@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.