From: Matt Porter <mporter@kernel.crashing.org>
To: Tom Rini <trini@kernel.crashing.org>,
Shawn Jin <shawnxjin@gmail.com>,
ppcembed <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] Ebony's UBoot awareness
Date: Wed, 23 Feb 2005 14:20:46 -0700 [thread overview]
Message-ID: <20050223142046.A13087@cox.net> (raw)
In-Reply-To: <20050223191247.GC6670@gate.ebshome.net>; from ebs@ebshome.net on Wed, Feb 23, 2005 at 11:12:47AM -0800
On Wed, Feb 23, 2005 at 11:12:47AM -0800, Eugene Surovegin wrote:
> On Wed, Feb 23, 2005 at 12:01:23PM -0700, Tom Rini wrote:
> > > +#include "../../../../drivers/net/ibm_emac/ibm_emac_phy.h"
> >
> > This will not work with O= for example. The correct method is to modify
> > the Makefile with a CFLAGS_foo.o += -Idrivers/net/ibm_emac
>
> I just tested and it does work even with O= :).
>
> OTOH, I agree this is ugly hack (it was copied from ocotea.c, so blame
> Matt for it :) and should be fixed correctly by moving those PHY
> defines to some common include.
Ugh, yes...in my defense I clearly stated it was an "ugly hack". :)
-Matt
next prev parent reply other threads:[~2005-02-23 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 18:39 [PATCH] Ebony's UBoot awareness Shawn Jin
2005-02-23 19:01 ` Tom Rini
2005-02-23 19:12 ` Eugene Surovegin
2005-02-23 21:20 ` Matt Porter [this message]
2005-02-23 21:24 ` Matt Porter
2005-02-24 21:43 ` Shawn Jin
2005-02-24 22:27 ` Matt Porter
2005-03-01 21:02 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050223142046.A13087@cox.net \
--to=mporter@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=shawnxjin@gmail.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.