Re: [Xen-devel][PATCH] dynamic libraries

["Vincent Hanquez" <tab@snarc.org>]

On Wed, Feb 23, 2005 at 11:43:23PM +0000, Keir Fraser wrote:
> Okay, well I shall change to -fPIC as the default and just not build 
> static libraries. Seems pointless having both static and dynamic.

Hi Keir,

Without the following patch %ebx is spilled in fpic mode.
(%ebx hold the GOT in this mode)

--- xeno-unstable.bk/tools/libxc/xc_vmx_build.c.orig	2005-02-09 13:50:48 +0100
+++ xeno-unstable.bk/tools/libxc/xc_vmx_build.c	2005-02-09 13:51:33 +0100
@@ -426,10 +426,10 @@
 {
     int eax, ecx;
 
-    __asm__ __volatile__ ("cpuid" 
+    __asm__ __volatile__ ("pushl %%ebx; cpuid; popl %%ebx" 
 			  : "=a" (eax), "=c" (ecx) 
 			  : "0" (1) 
-			  : "bx", "dx");
+			  : "dx");
     if (!(ecx & VMX_FEATURE_FLAG)) {
         return -1;
     }


-- 
Vincent Hanquez


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click