From: Ryan Anderson <ryan@michonline.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Guillaume Thouvenin <guillaume.thouvenin@bull.net>,
linux-kernel@vger.kernel.org, johnpol@2ka.mipt.ru,
elsa-devel@lists.sourceforge.net, jlan@engr.sgi.com,
gh@us.ibm.com, efocht@hpce.nec.com
Subject: Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector
Date: Thu, 24 Feb 2005 10:47:05 -0500 [thread overview]
Message-ID: <20050224154704.GC7828@mythryan2.michonline.com> (raw)
In-Reply-To: <20050224024605.76e7369f.akpm@osdl.org>
On Thu, Feb 24, 2005 at 02:46:05AM -0800, Andrew Morton wrote:
> Guillaume Thouvenin <guillaume.thouvenin@bull.net> wrote:
>
> > +spinlock_t fork_cn_lock = SPIN_LOCK_UNLOCKED;
>
> This should have static scope, and could be local to fork_connector().
>
> Please use DEFINE_SPINLOCK(). (There's a reason for this, but I forget
> what it was).
Static analysis tools, IIRC. (Stanford checker, sparse)
--
Ryan Anderson
sometimes Pug Majere
next prev parent reply other threads:[~2005-02-24 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 10:24 [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector Guillaume Thouvenin
2005-02-24 10:45 ` Evgeniy Polyakov
2005-02-24 12:05 ` Guillaume Thouvenin
2005-02-24 10:46 ` Andrew Morton
2005-02-24 15:47 ` Ryan Anderson [this message]
2005-02-25 16:54 ` aq
2005-02-25 17:19 ` Tim Schmielau
2005-02-25 18:13 ` Chris Wright
2005-03-02 8:48 ` Guillaume Thouvenin
2005-03-02 14:51 ` Paul Jackson
2005-03-02 17:48 ` Jesse Barnes
2005-03-02 15:50 ` Paul Jackson
2005-03-03 3:18 ` Kaigai Kohei
2005-03-03 5:46 ` Evgeniy Polyakov
2005-03-03 11:51 ` Evgeniy Polyakov
2005-03-03 12:20 ` Evgeniy Polyakov
2005-03-08 7:29 ` Guillaume Thouvenin
2005-03-08 8:45 ` Guillaume Thouvenin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050224154704.GC7828@mythryan2.michonline.com \
--to=ryan@michonline.com \
--cc=akpm@osdl.org \
--cc=efocht@hpce.nec.com \
--cc=elsa-devel@lists.sourceforge.net \
--cc=gh@us.ibm.com \
--cc=guillaume.thouvenin@bull.net \
--cc=jlan@engr.sgi.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.