From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christer Weinigel <christer@weinigel.se>, linux-kernel@vger.kernel.org
Subject: [2.6 patch] i386 scx200.c: misc cleanups
Date: Fri, 25 Feb 2005 00:37:32 +0100 [thread overview]
Message-ID: <20050224233732.GP8651@stusta.de> (raw)
The patch below contains the following cleanups:
- make some needlessly global code static
- #if 0 the following unused global functions:
- scx200_gpio_dump
- remove the following unneeded EXPORT_SYMBOL's:
- scx200_gpio_lock
- scx200_gpio_dump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 16 Jan 2005
arch/i386/kernel/scx200.c | 9 ++++-----
include/linux/scx200_gpio.h | 2 --
2 files changed, 4 insertions(+), 7 deletions(-)
--- linux-2.6.11-rc1-mm1-full/include/linux/scx200_gpio.h.old 2005-01-16 04:45:06.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/linux/scx200_gpio.h 2005-01-16 04:45:20.000000000 +0100
@@ -1,10 +1,8 @@
#include <linux/spinlock.h>
u32 scx200_gpio_configure(int index, u32 set, u32 clear);
-void scx200_gpio_dump(unsigned index);
extern unsigned scx200_gpio_base;
-extern spinlock_t scx200_gpio_lock;
extern long scx200_gpio_shadow[2];
#define scx200_gpio_present() (scx200_gpio_base!=0)
--- linux-2.6.11-rc1-mm1-full/arch/i386/kernel/scx200.c.old 2005-01-16 04:44:09.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/kernel/scx200.c 2005-01-16 04:45:28.000000000 +0100
@@ -37,7 +37,6 @@
.probe = scx200_probe,
};
-DEFINE_SPINLOCK(scx200_gpio_lock);
static DEFINE_SPINLOCK(scx200_gpio_config_lock);
static int __devinit scx200_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
@@ -81,6 +80,7 @@
return config;
}
+#if 0
void scx200_gpio_dump(unsigned index)
{
u32 config = scx200_gpio_configure(index, ~0, 0);
@@ -112,15 +112,16 @@
printk(" DEBOUNCE"); /* debounce */
printk("\n");
}
+#endif /* 0 */
-int __init scx200_init(void)
+static int __init scx200_init(void)
{
printk(KERN_INFO NAME ": NatSemi SCx200 Driver\n");
return pci_module_init(&scx200_pci_driver);
}
-void __exit scx200_cleanup(void)
+static void __exit scx200_cleanup(void)
{
pci_unregister_driver(&scx200_pci_driver);
release_region(scx200_gpio_base, SCx200_GPIO_SIZE);
@@ -131,9 +132,7 @@
EXPORT_SYMBOL(scx200_gpio_base);
EXPORT_SYMBOL(scx200_gpio_shadow);
-EXPORT_SYMBOL(scx200_gpio_lock);
EXPORT_SYMBOL(scx200_gpio_configure);
-EXPORT_SYMBOL(scx200_gpio_dump);
/*
Local variables:
next reply other threads:[~2005-02-24 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 23:37 Adrian Bunk [this message]
2005-02-25 14:19 ` [2.6 patch] i386 scx200.c: misc cleanups Henrik Brix Andersen
-- strict thread matches above, loose matches on Subject: below --
2005-01-16 8:15 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050224233732.GP8651@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=christer@weinigel.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.