Re: [2.6 patch] unexport do_settimeofday

[Adrian Bunk <bunk@stusta.de>]

On Fri, Feb 25, 2005 at 01:55:04PM -0800, Andrew Morton wrote:
>...
> --- 25/include/linux/compiler.h~a	2005-02-25 13:53:32.000000000 -0800
> +++ 25-akpm/include/linux/compiler.h	2005-02-25 13:54:45.000000000 -0800
> @@ -86,6 +86,12 @@ extern void __chk_io_ptr(void __iomem *)
>  # define __deprecated		/* unimplemented */
>  #endif
>  
> +#ifdef MODULE
> +#define __deprecated_in_modules __deprecated
> +#else
> +#define __deprecated_in_modules /* OK in non-modular code */
> +#endif
> +
>...

Looks good.


One more question:

You get a false positive if the file containing the symbol is itself a 
module.

Is there any way to solve this without additional #define's and #ifdef's 
for each symbol?


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed