From: Adrian Bunk <bunk@stusta.de>
To: Christoph Hellwig <hch@infradead.org>,
andrew.vasquez@qlogic.com, James.Bottomley@SteelEye.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups
Date: Mon, 28 Feb 2005 22:53:55 +0100 [thread overview]
Message-ID: <20050228215355.GQ4021@stusta.de> (raw)
In-Reply-To: <20050228212920.GA18162@infradead.org>
On Mon, Feb 28, 2005 at 09:29:20PM +0000, Christoph Hellwig wrote:
> On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote:
> > This patch contains the following cleanups:
> > - make needlessly global code static
> > - kill the unused global *_version and *_version_str variables
> > in the firmware files
>
> The firmware files are generated, so it'd be better to leave them
> alone.
Agreed.
But can't the generation of these files omit these needless variables
(there are already #define's containing the version information)?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-02-28 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 21:00 [2.6 patch] drivers/scsi/qla2xxx/: cleanups Adrian Bunk
2005-02-28 21:29 ` Christoph Hellwig
2005-02-28 21:53 ` Adrian Bunk [this message]
2005-02-28 21:56 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228215355.GQ4021@stusta.de \
--to=bunk@stusta.de \
--cc=James.Bottomley@SteelEye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.