From: "David S. Miller" <davem@davemloft.net>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: benh@au1.ibm.com, linux-arch@vger.kernel.org
Subject: Re: [PATCH] set_pte() part 1 (was Re: [PATCH] ppc32: Wrong vaddr in flush_hash_one_pte())
Date: Tue, 1 Mar 2005 15:30:00 -0800 [thread overview]
Message-ID: <20050301153000.0aaf5ec2.davem@davemloft.net> (raw)
In-Reply-To: <OFD7F7A9B4.F974A695-ON41256FB6.0032AFFD-41256FB6.0033EA43@de.ibm.com>
On Mon, 28 Feb 2005 10:27:03 +0100
Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> > In that case, please fix this simply by turning ptep_clear_flush()
> > (and thus ptep_establish) into a macro to fix the build as we have
> > done on the other platforms.
>
> Please don't. There are too many macros from hell as things are now.
> I prefer to sort out the compile errors with my inline functions than
> to introduce more of that macro crap.
>
> Simply expand the pte_clear inline into ptep_get_and_clear &
> ptep_clear_flush gets you around the problem with deferencing "vma"
> because on s390 we don't need the mm struct in pte_clear.
I'll do as you wish no problem.
But you will need to address this should you ever want to
experiment with batched TLB flushing. And I highly encourage
anyone with TLBs lacking true range flushing in hardware to
do so :-) It is such an incredible improvement.
next prev parent reply other threads:[~2005-03-01 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 8:02 [PATCH] ppc32: Wrong vaddr in flush_hash_one_pte() Benjamin Herrenschmidt
2005-02-24 0:11 ` [PATCH] set_pte() part 1 (was Re: [PATCH] ppc32: Wrong vaddr in flush_hash_one_pte()) David S. Miller
2005-02-25 9:32 ` Martin Schwidefsky
2005-02-25 23:43 ` David S. Miller
2005-02-28 9:27 ` Martin Schwidefsky
2005-03-01 23:30 ` David S. Miller [this message]
2005-03-02 8:23 ` Martin Schwidefsky
2005-02-25 13:29 ` Paul Mundt
2005-02-25 23:43 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-02-24 0:55 Luck, Tony
2005-02-24 4:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050301153000.0aaf5ec2.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@au1.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.