From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1D6bfk-0000Zx-FX for mharc-grub-devel@gnu.org; Wed, 02 Mar 2005 16:46:24 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D6bfg-0000Xj-O2 for grub-devel@gnu.org; Wed, 02 Mar 2005 16:46:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D6bff-0000Wx-Kn for grub-devel@gnu.org; Wed, 02 Mar 2005 16:46:19 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D6bff-0000Wi-EJ for grub-devel@gnu.org; Wed, 02 Mar 2005 16:46:19 -0500 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D6bRV-0001Vi-E2 for grub-devel@gnu.org; Wed, 02 Mar 2005 16:31:41 -0500 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 81F75FF0B4CF for ; Wed, 2 Mar 2005 22:31:39 +0100 (CET) Received: from 127.0.0.1 ([127.0.0.1] helo=localhost) by ASSP-nospam ; 2 Mar 05 21:31:39 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Wed, 2 Mar 2005 22:33:18 +0100 User-Agent: KMail/1.7.1 References: <4219D62D.3000109@omniflux.com> In-Reply-To: <4219D62D.3000109@omniflux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200503022233.18661.okuji@enbug.org> Subject: Re: x86 serial support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2005 21:46:21 -0000 Sorry, I forgot to send a reply. On Monday 21 February 2005 13:38, Omniflux wrote: > Here is a patch to add serial support to x86. Great. > If this is headed in the right direction, and likely to be accepted > for merging with a little more work, I'll keep working on it. I think this is a good way. But some problems must be solved: - Naming issues. Since you copied the code from GRUB Legacy, some names are not appropriate in GRUB 2. For example, the global function declared in terminfo.h do not use the prefix 'grub_' at all. - Module separation. I think it would be better to have a separate module for terminfo, because we might be able to use it for other terminals as well as serial console, say, parallel console. - ChangeLog. Please write ChangeLog entries for your changes. BTW, do you have any suggestion about the so-called "dumb terminal"? Because supporting dumb terminal is horrible, I hesitate to support it in GRUB 2, if there is no clean way to do it. Okuji