From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [RFC][PATCH 2/5] char/tpqic02: use poll_event*() interface
Date: Thu, 03 Mar 2005 18:25:41 +0000 [thread overview]
Message-ID: <20050303182541.GE11600@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
Hi,
Description: Use new poll_event*() interface to encapsulate sleep-loops.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-kj-v/drivers/char/tpqic02.c 2005-03-01 23:38:09.000000000 -0800
+++ 2.6.11-kj/drivers/char/tpqic02.c 2005-03-03 10:23:59.000000000 -0800
@@ -527,18 +527,14 @@ static int wait_for_ready(time_t timeout
return TE_OK; /* covers 99.99% of all calls */
/* Then use schedule() a few times */
- spin_t = 3; /* max 0.03 sec busy waiting */
+ spin_t = 3; /* request max 0.003 sec busy waiting */
if (spin_t > timeout)
spin_t = timeout;
timeout -= spin_t;
spin_t += jiffies;
/* FIXME...*/
- while (((stat = inb_p(QIC02_STAT_PORT) & QIC02_STAT_MASK) == QIC02_STAT_MASK) && time_before(jiffies, spin_t))
- {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(1); /* don't waste all the CPU time */
- }
+ poll_event_timeout(((stat = inb_p(QIC02_STAT_PORT) & QIC02_STAT_MASK) != QIC02_STAT_MASK), 1, spin_t);
if ((stat & QIC02_STAT_READY) == 0)
return TE_OK;
@@ -552,12 +548,8 @@ static int wait_for_ready(time_t timeout
TPQDEB({printk("wait_for_ready: additional timeout: %d\n", spin_t);})
/* not ready and no exception && timeout not expired yet */
- while (((stat = inb_p(QIC02_STAT_PORT) & QIC02_STAT_MASK) == QIC02_STAT_MASK) && time_before(jiffies, spin_t)) {
- /* be `nice` to other processes on long operations... */
- /* nap 0.30 sec between checks, */
- /* but could be woken up earlier by signals... */
- msleep_interruptible(300);
- }
+ poll_event_interruptible_timeout(((stat = inb_p(QIC02_STAT_PORT) & QIC02_STAT_MASK) != QIC02_STAT_MASK),
+ 300, spin_t);
/* don't use jiffies for this test because it may have changed by now */
if ((stat & QIC02_STAT_MASK) == QIC02_STAT_MASK) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-03-03 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 18:25 Nishanth Aravamudan [this message]
2005-03-03 20:32 ` [KJ] [RFC][PATCH 2/5] char/tpqic02: use poll_event*() interface Nishanth Aravamudan
2005-03-05 1:15 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050303182541.GE11600@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.