From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262839AbVCDLL2 (ORCPT ); Fri, 4 Mar 2005 06:11:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262769AbVCDLFz (ORCPT ); Fri, 4 Mar 2005 06:05:55 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:39868 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S262785AbVCDLE0 (ORCPT ); Fri, 4 Mar 2005 06:04:26 -0500 Date: Fri, 4 Mar 2005 12:04:08 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Andi Kleen , kernel list , paul.devriendt@amd.com Subject: Re: BIOS overwritten during resume (was: Re: Asus L5D resume on battery power) Message-ID: <20050304110408.GL1345@elf.ucw.cz> References: <200502252237.04110.rjw@sisk.pl> <200503030047.43625.rjw@sisk.pl> <20050302235456.GB1439@elf.ucw.cz> <200503030902.48038.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503030902.48038.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > IIRC kernel code/data is marked as PageReserved(), that's why we need > > to save that :(. Not sure what to do with data e820 marked as > > reserved... > > Perhaps we need another page flag, like PG_readonly, and mark the pages > reserved by the e820 as PG_reserved | PG_readonly (the same for the areas > that are not returned by e820 at all). Would that be acceptable? This flags are little in the short supply, but being able to tell kernel code from memory hole seems like "must have", so yes, that looks ok. You could get subtle and reuse some other pageflag. I do not think PG_reserved can have PG_locked... So using for example PG_locked for this purpose should be okay. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!