All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [Patch 0/3] Page table quicklist fixups Rev 3.
Date: Fri, 04 Mar 2005 22:33:56 +0000	[thread overview]
Message-ID: <200503042233.j24MXug29211@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050303212359.GA732@lnx-holt.americas.sgi.com>

Luck, Tony wrote on Friday, March 04, 2005 11:58 AM
> >You tell me what to do.
>
> At the moment I'm hoping somebody smarter will chime into this thread
> (either to point out a great solution, or to tell me that I'm a dork
> and this code is perfectly reasonable, so I should quit quibbling).
>
> Overall the patch is great ... it's solving a real problem in an elegant
> way.  It's just this little corner of how to shrink the quicklists that
> I'm trying to get right.

One other possible solution I can think of is to use schedule_delayed_work
API.  You can schedule one per node every one second interval and have the
work function re-arm itself.  It has several pros:

1. Addresses the concern that Tony has with SETI eating up all the idle
   ticks and check_pgt_cache() may never get a chance to run.
2. once work is scheduled, you don't need to dance with batch count.
   Just keep on freeing in one while loop since it is running in a kernel
   thread.
3. Potentially, call to check_pgt_cache from tlb_finish_mmu() can be
   removed, making process exit faster.
4. And last, probably not important, addresses my concern of broken model
   (freeing memory in idle loop).

Just my 2 cents, only worth what's on the paper.

- Ken



  parent reply	other threads:[~2005-03-04 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-03 21:23 [Patch 0/3] Page table quicklist fixups Rev 3 Robin Holt
2005-03-03 21:57 ` Luck, Tony
2005-03-04  8:03 ` Zou Nan hai
2005-03-04  8:46 ` Robin Holt
2005-03-04 14:55 ` Robin Holt
2005-03-04 16:25 ` Robin Holt
2005-03-04 19:58 ` Luck, Tony
2005-03-04 22:33 ` Chen, Kenneth W [this message]
2005-03-07 12:57 ` Robin Holt
2005-03-08 23:56 ` Luck, Tony
2005-03-15 19:33 ` [Patch 0/3] Page table quicklist fixups Rev 4 Robin Holt
2005-03-16  0:24 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503042233.j24MXug29211@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.