All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length
Date: Sat, 5 Mar 2005 17:23:23 +0100	[thread overview]
Message-ID: <20050305162323.GM31837@postel.suug.ch> (raw)
In-Reply-To: <20050305005911.GA27804@gondor.apana.org.au>

* Herbert Xu <20050305005911.GA27804@gondor.apana.org.au> 2005-03-05 11:59
> On Sat, Mar 05, 2005 at 01:29:10AM +0100, Thomas Graf wrote:
> > 
> > I've been thinking about this since yesterday and the best solution I
> > came up so far is to encode it in one of the yet unused bits in
> > the prefixlength field. After all we're only using 5bits of it. What
> > i'm thinking of in particular is to encode it as in 1 bit wildcard
> > flag 5 bits prefix length.
> 
> That's sound fine as long as we treat the current ip(8) prefix length
> as a wild card.

Although we should keep the behaviour of ip a a 1.1.1.1/24; ip a d
1.1.1.1, what about ip a a 1.1.1.1/24; ip a d 1.1.1.1/16? I think the
latter should not result in a deletion. We could achieve this by checking
the prefix length if either the exact-match flag is set or the 
prefixlength is != 32. This is of course quite minor and only affects
old iproute2 versions in combination with newer kernels.

Thougts?

  reply	other threads:[~2005-03-05 16:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04  1:20 [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length Thomas Graf
2005-03-04  8:31 ` Herbert Xu
2005-03-04 13:14   ` Thomas Graf
2005-03-04 20:40     ` Herbert Xu
2005-03-04 20:46       ` Herbert Xu
2005-03-04 23:32     ` Herbert Xu
2005-03-05  0:29       ` Thomas Graf
2005-03-05  0:31         ` Thomas Graf
2005-03-05  0:46         ` Patrick McHardy
2005-03-05  1:03           ` Herbert Xu
2005-03-05  1:11             ` Patrick McHardy
2005-03-05  1:20               ` Thomas Graf
2005-03-05  1:28                 ` Patrick McHardy
2005-03-05  0:59         ` Herbert Xu
2005-03-05 16:23           ` Thomas Graf [this message]
2005-03-05 18:30             ` Herbert Xu
2005-03-08 16:01               ` [PATCH] [NET]: Fix deletion of equal local IPv4 " Thomas Graf
2005-03-04 13:30   ` [PATCH] [NET]: Fix deletion of local " Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050305162323.GM31837@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.