From: Francois Romieu <romieu@fr.zoreil.com>
To: domen@coderock.org
Cc: axboe@suse.de, linux-kernel@vger.kernel.org, c.lucas@ifrance.com
Subject: Re: [patch 14/15] drivers/block/*: convert to pci_register_driver
Date: Sun, 6 Mar 2005 00:21:53 +0100 [thread overview]
Message-ID: <20050305232153.GA28664@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20050305224327.781571F07A@trashy.coderock.org>
domen@coderock.org <domen@coderock.org> :
[...]
> diff -puN drivers/block/umem.c~pci_register_driver-drivers_block drivers/block/umem.c
> --- kj/drivers/block/umem.c~pci_register_driver-drivers_block 2005-03-05 16:12:16.000000000 +0100
> +++ kj-domen/drivers/block/umem.c 2005-03-05 16:12:16.000000000 +0100
> @@ -1185,7 +1185,7 @@ int __init mm_init(void)
>
> printk(KERN_INFO DRIVER_VERSION " : " DRIVER_DESC "\n");
>
> - retval = pci_module_init(&mm_pci_driver);
> + retval = pci_register_driver(&mm_pci_driver);
> if (retval)
> return -ENOMEM;
The return code is fine and does not need to be overwritten.
Imho it could be considered to be part of the patch.
--
Ueimor
prev parent reply other threads:[~2005-03-05 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 22:43 [patch 14/15] drivers/block/*: convert to pci_register_driver domen
2005-03-05 23:03 ` Jeff Garzik
2005-03-05 23:21 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050305232153.GA28664@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=axboe@suse.de \
--cc=c.lucas@ifrance.com \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.