From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: alan@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
luc@saillard.org, torvalds@osdl.org
Subject: Re: [PATCH] Restore PWC driver
Date: Tue, 8 Mar 2005 05:34:06 +0000 [thread overview]
Message-ID: <20050308053405.GA1172@infradead.org> (raw)
In-Reply-To: <20050308052643.GA16222@kroah.com>
On Mon, Mar 07, 2005 at 09:26:43PM -0800, Greg KH wrote:
> Ick, Alan, couldn't you have had the decency to run this through the USB
> developers, and at least pinged me on it? Especially due to all of the
> hate-email I have gotten over this driver in the past.
>
> As it is, the coding style sucks in places, and you didn't really need
> to make it a new subdirectory (although due to the increased size of the
> driver, it's probably better now...)
>
> And, there's no MAINTAINERS entry for who I need to bug about this
> thing.
Agree with greg on all these bits, and similar (although not as bad) for
the other bits Alan sent. Alan, could you please go through the subsystem
maintainer & -mm process like everyone else? A little public review
can't hurt your patches either.
next prev parent reply other threads:[~2005-03-08 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200503072216.j27MGLqR024373@hera.kernel.org>
2005-03-08 5:26 ` [PATCH] Restore PWC driver Greg KH
2005-03-08 5:32 ` Greg KH
2005-03-08 10:01 ` Alan Cox
2005-03-08 5:34 ` Christoph Hellwig [this message]
2005-03-08 10:01 ` Alan Cox
2005-03-08 11:11 ` Andrew Morton
2005-03-08 8:15 ` Luc Saillard
2005-03-08 10:03 ` Alan Cox
2005-03-08 9:59 ` Alan Cox
2005-03-08 14:13 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308053405.GA1172@infradead.org \
--to=hch@infradead.org \
--cc=alan@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc@saillard.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.