From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH] unified device list allocator
Date: Tue, 8 Mar 2005 05:43:25 +0000 [thread overview]
Message-ID: <20050308054325.GA1262@infradead.org> (raw)
In-Reply-To: <20050307213302.560de053.akpm@osdl.org>
On Mon, Mar 07, 2005 at 09:33:02PM -0800, Andrew Morton wrote:
> Matt Mackall <mpm@selenic.com> wrote:
> >
> > + /* search for insertion point in reverse for dynamic allocation */
> > + list_for_each_prev(l, list) {
>
> hrmph. Any time we do anything in O(n) time, some smarty comes along with
> a workload which blows us out of the water. Although it's hard to think of
> any register_blkdev()-intensive workloads.
>
> It's not possible to do this with prio-trees?
Andrew, I think in this particular case you suffer of a sporadic severe
condition of overengineeritis.
register_blkdev only happens at module_init time (and in fact should go
away completely, so I'm not happy wit hthe surgey to keep it barely alive
at all)
next prev parent reply other threads:[~2005-03-08 5:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 5:18 [PATCH] unified device list allocator Matt Mackall
2005-03-08 5:33 ` Andrew Morton
2005-03-08 5:43 ` Christoph Hellwig [this message]
2005-03-08 5:50 ` Andrew Morton
2005-03-08 5:56 ` Christoph Hellwig
2005-03-08 6:11 ` Matt Mackall
2005-03-08 6:31 ` Christoph Hellwig
2005-03-08 6:35 ` Matt Mackall
2005-03-08 6:01 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050308054325.GA1262@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.