From: Johannes Stezenbach <js@linuxtv.org>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org
Subject: Re: [linux-dvb] [patch] dvb: add pll lib
Date: Wed, 9 Mar 2005 02:37:33 +0100 [thread overview]
Message-ID: <20050309013733.GA21386@linuxtv.org> (raw)
In-Reply-To: <20050308105726.GA30986@bytesex>
(linux-dvb list removed from Cc: because it is subscribers only)
On Tue, Mar 08, 2005 at 11:57:26AM +0100, Gerd Knorr wrote:
> This adds some helper code to handle tuning for dvb cards,
> with a struct describing the pll and a function calculating
> the command sequence needed to program it.
>
> This one was discussed + accepted on the linuxtv list and
> also is in the linuxtv cvs. As the the cx88 driver update
> I want finally get out of the door depends on this one I'll
> go submit it myself instead of waiting for the dvb guys doing
> it.
Michael Hunold is somewhat busy with his new job at Toshiba, so I want
to takeover patch submission for now. However, one thing that makes it
difficult to create kernel patches from linuxtv.org CVS is that there
are a large number of whitespace differences between the kernel tree and
CVS. There's also some corrupted indentation in the kernel, e.g.
drivers/media/dvb/frontends/tda1004x.c:tda1004x_sleep().
I wanted to get this issue out of the way before I start
to submit other patches from linuxtv.org CVS.
I merged some whitespace cleanups from the kernel into CVS,
and created a patch to clean up whitespace in the kernel,
removing lots of whitespace at end-of-line in the go.
The problem with this patch is that it is huge (600K) :-(.
I was crazy enough to mail it to Linus anyway on Sunday,
and it looks like it got dropped on the floor :-((
It would be nice if I could get some advice how to submit this kind of
cleanup (i.e. if I should split it up in tiny fragments), or if I
should ignore the issue for now and concentrate on functional
improvements.
The DVB related patches submitted by Gerd are non-controversial
and should be applied.
Johannes
prev parent reply other threads:[~2005-03-09 1:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 10:57 [patch] dvb: add pll lib Gerd Knorr
2005-03-09 1:37 ` Johannes Stezenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050309013733.GA21386@linuxtv.org \
--to=js@linuxtv.org \
--cc=akpm@osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.