From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261613AbVCIHkE (ORCPT ); Wed, 9 Mar 2005 02:40:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261641AbVCIHkD (ORCPT ); Wed, 9 Mar 2005 02:40:03 -0500 Received: from mail.kroah.org ([69.55.234.183]:23448 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261613AbVCIHjc (ORCPT ); Wed, 9 Mar 2005 02:39:32 -0500 Date: Tue, 8 Mar 2005 23:36:16 -0800 From: Greg KH To: Benjamin Herrenschmidt , Linus Torvalds , Andrew Morton , jt@hpl.hp.com, linux-pcmcia@lists.infradead.org, Kernel Mailing List Subject: Re: PCMCIA product id strings -> hashes generation at compilation time? [Was: Re: [patch 14/38] pcmcia: id_table for wavelan_cs] Message-ID: <20050309073616.GB19367@kroah.com> References: <20050227161308.GO7351@dominikbrodowski.de> <20050307225355.GB30371@bougret.hpl.hp.com> <20050307230102.GA29779@isilmar.linta.de> <20050307150957.0456dd75.akpm@osdl.org> <20050307232339.GA30057@isilmar.linta.de> <20050308191138.GA16169@isilmar.linta.de> <20050308231636.GA20658@isilmar.linta.de> <1110347109.32524.56.camel@gaston> <20050309071942.GA28231@isilmar.linta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050309071942.GA28231@isilmar.linta.de> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2005 at 08:19:42AM +0100, Dominik Brodowski wrote: > On Wed, Mar 09, 2005 at 04:45:09PM +1100, Benjamin Herrenschmidt wrote: > > On Wed, 2005-03-09 at 00:16 +0100, Dominik Brodowski wrote: > > > > Dominik Brodowski wrote: > > > > > > > > > > Most pcmcia devices are matched to drivers using "product ID strings" > > > > > embedded in the devices' Card Information Structures, as "manufactor ID / > > > > > card ID" matches are much less reliable. Unfortunately, these strings cannot > > > > > be passed to userspace for easy userspace-based loading of appropriate > > > > > modules (MODNAME -- hotplug), so my suggestion is to also store crc32 hashes > > > > > of the strings in the MODULE_DEVICE_TABLEs, e.g.: > > > > > > > > > > PCMCIA_DEVICE_PROD_ID12("LINKSYS", "E-CARD", 0xf7cb0b07, 0x6701da11), > > > > > > > > What is the difficulty in passing these strings via /sbin/hotplug arguments? > > > > > > The difficulty is that extracting and evaluating them breaks the wonderful > > > bus-independent MODNAME implementation for hotplug suggested by Roman Kagan > > > ( http://article.gmane.org/gmane.linux.hotplug.devel/7039 ), and that these > > > strings may contain spaces and other "strange" characters. The latter may be > > > worked around, but the former cannot. /etc/hotplug/pcmcia.agent looks really > > > clean because of this MODNAME implementation: > > > > Same goes with Open Firmware match strings that we are about to pass > > down to userspace as well. Hotplug will have to learn to deal with > > those. > > Hotplug isn't the tricky part. file2alias is. Any idea on how to do that? I do not, sorry. Rusty's the person to bug about that. good luck, greg k-h