From: Blaisorblade <blaisorblade@yahoo.it>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [patch 1/1] x86-64: forgot asmlinkage on sys_mmap
Date: Wed, 9 Mar 2005 19:24:00 +0100 [thread overview]
Message-ID: <200503091924.00518.blaisorblade@yahoo.it> (raw)
In-Reply-To: <m1br9swx54.fsf@muc.de>
On Wednesday 09 March 2005 18:24, Andi Kleen wrote:
> blaisorblade@yahoo.it writes:
> > CC: Andi Kleen <ak@suse.de>
> >
> > I think it should be there, please check better.
>
> It doesn't matter. asmlinkage is a nop on x86-64.
Yes, otherwise nothing would work on x86-64 with mmap broken, but for
cleanness and for the case this change it should be there (otherwise why
asmlinkage is used in the rest of the file).
And for i386 asmlinkage acquired significance only recently.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
next prev parent reply other threads:[~2005-03-09 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 19:00 [patch 1/1] x86-64: forgot asmlinkage on sys_mmap blaisorblade
2005-03-09 17:24 ` Andi Kleen
2005-03-09 18:24 ` Blaisorblade [this message]
2005-03-09 19:34 ` Andi Kleen
2005-03-09 19:40 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503091924.00518.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=ak@muc.de \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.