Re: [PATCH] be more verbose in gen-devlist

[Greg KH <greg@kroah.com>]

On Fri, Mar 11, 2005 at 08:28:58PM +0100, Olaf Hering wrote:
> 
> gen-devlist should print how many bytes will be cut off and pci.ids
> entry. Also print the removed '[more blah]' part.
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
> --- ../linux-2.6.10/drivers/pci/gen-devlist.c	2004-12-24 22:34:45.000000000 +0100
> +++ ./drivers/pci/gen-devlist.c	2005-03-11 20:10:11.542098265 +0100
> @@ -72,9 +72,19 @@ main(void)
>  						/* Too long, try cutting off long description */
>  						bra = strchr(c, '[');
>  						if (bra && bra > c && bra[-1] == ' ')
> +#if 0
> +						{
> +							fprintf(stderr, "Line %d: cut off '%s' from line:\n", lino, bra);
> +							fprintf(stderr, " '%s'\n", c);
>  							bra[-1] = 0;
> +							fprintf(stderr, " '%s'\n", c);
> +						}
> +#else
> +							bra[-1] = 0;
> +#endif

Why #if this?  Why not just always do this?

thanks,

greg k-h