All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: John David Anglin <dave@hiauly1.hia.nrc.ca>
Cc: parisc-linux@lists.parisc-linux.org
Subject: [parisc-linux] Re: Comments?
Date: Mon, 14 Mar 2005 05:28:42 -0800	[thread overview]
Message-ID: <20050314132842.GE28289@tausq.org> (raw)
In-Reply-To: <200503131621.j2DGLrVd029395@hiauly1.hia.nrc.ca>

> Thinking more about this, I've decided that this change would
> tend to hide problems.  The reality is that fs/ioctl.c has to
> deal with how to convert the loff_t value to an int (e.g., return
> INT_MAX for positive offsets exceeding INT_MAX, or return an
> error, etc).  Truncation likely isn't the right thing to do
> in all cases.

I suppose the behavior should, ideally, match some specification.
Unfortunately the only place I can find where FIONREAD is documented is
in LSB, and the description there is quite value about what the return
type is supposed to be.

For now I've commited a combination of:
1) Change the FIONREAD handling code to explicitly return a 4-byte value
2) Change the put_user code to cast the result to the expected type

Willy says he will follow up with other relevant folks to find out
what's the right thing to do.

randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

  reply	other threads:[~2005-03-14 13:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 19:21 [parisc-linux] Comments? Carlos O'Donell
2005-03-02 19:41 ` [parisc-linux] Comments? John David Anglin
2005-03-02 21:37   ` Carlos O'Donell
2005-03-02 22:38     ` John David Anglin
2005-03-03  2:45       ` Carlos O'Donell
2005-03-03  3:21         ` John David Anglin
2005-03-05 19:46           ` Carlos O'Donell
2005-03-05 20:33             ` John David Anglin
2005-03-08 17:47               ` Carlos O'Donell
2005-03-12 23:37               ` John David Anglin
2005-03-13  1:19                 ` Randolph Chung
2005-03-13  2:39                   ` John David Anglin
2005-03-13 12:22                   ` Joel Soete
2005-03-13 16:21                   ` John David Anglin
2005-03-14 13:28                     ` Randolph Chung [this message]
2005-03-22  2:25                       ` John David Anglin
2005-03-23 17:29                         ` Matthew Wilcox
2005-03-23 20:53                           ` John David Anglin
2005-03-23 21:07                             ` John David Anglin
     [not found] <no.id>
2005-03-05 21:53 ` John David Anglin
2005-03-06  0:22   ` John David Anglin
2005-03-08 17:32     ` Carlos O'Donell
2005-03-08 17:44       ` John David Anglin
2005-03-08 17:54         ` Carlos O'Donell
2005-03-08 19:02           ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050314132842.GE28289@tausq.org \
    --to=randolph@tausq.org \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.