From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Knorr Subject: Re: [patch/unstable] page table cleanups Date: Mon, 14 Mar 2005 14:36:10 +0100 Message-ID: <20050314133610.GA13023@bytesex> References: <20050314120731.GA11829@bytesex> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Keir Fraser Cc: xen-devel@lists.sourceforge.net List-Id: xen-devel@lists.xenproject.org Hi, > The other is to change those unsigned longs into a physaddr_t which is > u64 on 32-bit PAE systems. I've considered doing something like that as well, but I don't think that this is a good idea. > I'm not fussed too much which way we go, but Ian has pointed out that > the l*_pgentry_t types haven't actually found us any bugs (although I > might argue that it has prevented any bugs ever getting as far as the > master repository :-) ). I'd argue that way as well. The whole point of the "typedef { u{32|64} l? } l?_pgentry_t" types and the access macros is to make the _compiler_ notice bugs, so they can't creep into the code base in the first place because gcc refuses to compile the buggy code ;) cheers, Gerd -- #define printk(args...) fprintf(stderr, ## args) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click