From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Knorr Subject: Re: [patch/unstable] page table cleanups Date: Mon, 14 Mar 2005 16:14:48 +0100 Message-ID: <20050314151448.GA13710@bytesex> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Ian Pratt Cc: Keir Fraser , xen-devel@lists.sourceforge.net, ian.pratt@cl.cam.ac.uk List-Id: xen-devel@lists.xenproject.org Hi, > I guess I'd prefer to have it be a scalar type because all the accessor > macros actually do a pretty good job of obfusticating the code -- you > see mk_( _val( X ) [logical op]) all over the place. Yes, that is not so nice ... > One way to fix this would be to have a better accessor macro for > performing logical ops on the flags field of a pgentry. I've already considered changing the accessor macros for performance reasons. With separate macros to read/write pfn and the flags it is also possible to get away with 32 bit instead of 64 bit operations for page flag checks and updates. I think I'll go this route then ;) Gerd -- #define printk(args...) fprintf(stderr, ## args) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click