From: Adrian Bunk <bunk@stusta.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] net/802/fc.c: remove fc_type_trans
Date: Tue, 15 Mar 2005 13:20:17 +0100 [thread overview]
Message-ID: <20050315122017.GF3189@stusta.de> (raw)
In-Reply-To: <20050314214940.4947ccd9.davem@davemloft.net>
On Mon, Mar 14, 2005 at 09:49:40PM -0800, David S. Miller wrote:
> On Sun, 6 Mar 2005 21:57:54 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > The only user of fc_type_trans (drivers/net/fc/iph5526.c) is BROKEN in
> > 2.6 and removed in -mm.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> That driver isn't in Linus's tree any longer either. Just delete
> the thing altogether instead of #if 0'ing it.
>...
Updated patch:
<-- snip -->
The only user of fc_type_trans (drivers/net/fc/iph5526.c) is removed in
Linus' tree.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/linux/fcdevice.h | 2 --
net/802/fc.c | 34 ----------------------------------
2 files changed, 36 deletions(-)
--- linux-2.6.11-mm1-full/include/linux/fcdevice.h.old 2005-03-06 21:40:36.000000000 +0100
+++ linux-2.6.11-mm1-full/include/linux/fcdevice.h 2005-03-06 21:41:07.000000000 +0100
@@ -24,12 +24,10 @@
#define _LINUX_FCDEVICE_H
#include <linux/if_fc.h>
#ifdef __KERNEL__
-extern unsigned short fc_type_trans(struct sk_buff *skb, struct net_device *dev);
-
extern struct net_device *alloc_fcdev(int sizeof_priv);
#endif
#endif /* _LINUX_FCDEVICE_H */
--- linux-2.6.11-mm3-full/net/802/fc.c.old 2005-03-15 13:02:13.000000000 +0100
+++ linux-2.6.11-mm3-full/net/802/fc.c 2005-03-15 13:02:34.000000000 +0100
@@ -97,40 +97,6 @@
#endif
}
-unsigned short
-fc_type_trans(struct sk_buff *skb, struct net_device *dev)
-{
- struct fch_hdr *fch = (struct fch_hdr *)skb->data;
- struct fcllc *fcllc;
-
- skb->mac.raw = skb->data;
- fcllc = (struct fcllc *)(skb->data + sizeof (struct fch_hdr) + 2);
- skb_pull(skb, sizeof (struct fch_hdr) + 2);
-
- if (*fch->daddr & 1) {
- if (!memcmp(fch->daddr, dev->broadcast, FC_ALEN))
- skb->pkt_type = PACKET_BROADCAST;
- else
- skb->pkt_type = PACKET_MULTICAST;
- } else if (dev->flags & IFF_PROMISC) {
- if (memcmp(fch->daddr, dev->dev_addr, FC_ALEN))
- skb->pkt_type = PACKET_OTHERHOST;
- }
-
- /*
- * Strip the SNAP header from ARP packets since we don't pass
- * them through to the 802.2/SNAP layers.
- */
- if (fcllc->dsap == EXTENDED_SAP &&
- (fcllc->ethertype == ntohs(ETH_P_IP) ||
- fcllc->ethertype == ntohs(ETH_P_ARP))) {
- skb_pull(skb, sizeof (struct fcllc));
- return fcllc->ethertype;
- }
-
- return ntohs(ETH_P_802_2);
-}
-
static void fc_setup(struct net_device *dev)
{
dev->hard_header = fc_header;
next prev parent reply other threads:[~2005-03-15 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 20:57 [2.6 patch] net/802/fc.c: #if 0 fc_type_trans Adrian Bunk
2005-03-15 5:49 ` David S. Miller
2005-03-15 12:20 ` Adrian Bunk [this message]
2005-03-15 18:26 ` [2.6 patch] net/802/fc.c: remove fc_type_trans David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315122017.GF3189@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.