From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: Re: [PATCH 5/5] s1d13xxxfb: Add support for Epson S1D13806 FB Date: Tue, 15 Mar 2005 14:01:17 +0800 Message-ID: <200503151401.17297.adaplas@hotpop.com> References: <200503150706.27357.adaplas@hotpop.com> <20050314184049.2ed12443.akpm@osdl.org> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1DB57V-0003pM-9E for linux-fbdev-devel@lists.sourceforge.net; Mon, 14 Mar 2005 22:01:33 -0800 Received: from smtp-out.hotpop.com ([38.113.3.61]) by sc8-sf-mx2.sourceforge.net with esmtp (Exim 4.41) id 1DB57R-0005Tj-GG for linux-fbdev-devel@lists.sourceforge.net; Mon, 14 Mar 2005 22:01:33 -0800 Received: from hotpop.com (kubrick.hotpop.com [38.113.3.103]) by smtp-out.hotpop.com (Postfix) with SMTP id CD91BF5EA4A for ; Tue, 15 Mar 2005 06:01:19 +0000 (UTC) In-Reply-To: <20050314184049.2ed12443.akpm@osdl.org> Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton , adaplas@pol.net Cc: linux-fbdev-devel@lists.sourceforge.net, varenet@esiee.fr On Tuesday 15 March 2005 10:40, Andrew Morton wrote: > "Antonino A. Daplas" wrote: > > Attached to that mail is a patch adding support for Epson S1D13806 > > framebuffer device. > > > > That driver is intended to be easily used with other S1D13xxx devices, > > hopefully by splitting the header file and changing a few defines. > > Since I haven't got the hardware to test that, though, I can only assert > > that it works with S1D13806. > > > > This driver has been succesfully tested on ARM embedded boards and > > reported working on SH architecture as well. > > > > Since this is my first framebuffer driver, I would welcome any > > suggestion/comment about it :) > > > > This driver has been built on top of some preliminary ARM specific > > work by Ben Dooks, and adapted from existing code (as stated in the > > header of s1d13xxxfb.c). > > > > Signed-off-by: Thibaut VARENE > > Signed-off-by: Antonino Daplas > > I've been going around editing From: lines recently, in cases where it's > obvious. I did so with this patch - please let me know if that is > inappropariate. No, this is okay. > > > So the patch will hit bk as: > > From: Thibaut VARENE > Signed-off-by: Thibaut VARENE > Signed-off-by: Antonino Daplas > Signed-off-by: Andrew Morton > > > So > > a) Thibaut will be identified in the bk logs as the author > > b) His name will appear in the short-form changelogs, etc. > > c) The Signed-off-by: line will note that Tony and I also handled this > patch, and possibly made small changes to it. > > I do this so that contributors get suitable credit, and so that bug > reporters have a better chance of finding who to email on the first > attempt. > With the patches I send you, the first one in the signed-off line is the original contributor of the patch and the changelog. If the original contributor did not sign-off, I add a 'From: ' with or without the e-mail address at the very beginning of the changelog. Anyway, would you like to me to follow the format below to make it easier for you? > From: Thibaut VARENE > Signed-off-by: Thibaut VARENE > Signed-off-by: Antonino Daplas > Signed-off-by: Andrew Morton Tony ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click