Re: [PATCH][2.6.11] generic_serial.h gcc4 fix

[Adrian Bunk <bunk@stusta.de>]

On Tue, Mar 15, 2005 at 06:13:33PM +0100, Mikael Pettersson wrote:
> Fix
> 
> drivers/char/generic_serial.c:38: error: static declaration of 'gs_debug' follows non-static declaration
> include/linux/generic_serial.h:94: error: previous declaration of 'gs_debug' was here
> 
> compilation error from gcc4 in generic_serial.h.
> 
> /Mikael
> 
> --- linux-2.6.11/include/linux/generic_serial.h.~1~	2005-03-02 19:24:19.000000000 +0100
> +++ linux-2.6.11/include/linux/generic_serial.h	2005-03-15 17:11:07.000000000 +0100
> @@ -91,6 +91,4 @@ int  gs_setserial(struct gs_port *port, 
>  int  gs_getserial(struct gs_port *port, struct serial_struct __user *sp);
>  void gs_got_break(struct gs_port *port);
>  
> -extern int gs_debug;
> -
>  #endif

This patch is already in -mm for ages.

When doing such patches, -mm is usually a better basis than Linus' tree.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed