Re: [PATCH] miroSOUND PCM12 driver

[Martin Langer <martin-langer@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]

On Wed, Mar 16, 2005 at 11:51:46AM +0100, Clemens Ladisch wrote:
> Martin Langer wrote:
> > The tenth birthday of this card is coming soon and now it's time to get
> > an ALSA driver for the miroSOUND PCM12 :)

The new miro driver patch version 0.6 is attached.

> 
> > +++ alsa-driver/isa/opti9xx/Makefile	Fri Mar 11 18:51:05 2005
> > +obj-$(CONFIG_SND_MIRO) += snd-miro.o snd-opti92x-cs4231.o
> 
> Is there any reason for the dependency on the snd-opti92x-cs4231
> driver?

No, it's rubbish. I've removed it.

> > MODULE_SUPPORTED_DEVICE("{{miroSOUND,PCM1 pro}, "
> > 			"{miroSOUND,PCM12}, "
> > 			"{miroSOUND,PCM20 Radio}}");
> 
> The first entry in each pair should be the vendor name.

fixed.

> > static int wss;                                 /* unknown range */
> > static int ide;                                 /* unknown range */
> 
> "unknown"? :-)

"wss" is only for PCM1 which I can't test with my PCM12.

"ide" isn't documented and I haven't tried ide out - it's postponed to 
later.

But perhaps 0 and 1 are the unknown values. Hmmm, there is still a 
smell of uncertainty in the air...

> > int snd_miro_mixer(miro_t * miro)
> > ...
> > 	switch (miro->hardware) {
> >         case OPTi9XX_HW_82C924:
> > 		strcpy(card->mixername, "ACI & OPTi924");
> >         case OPTi9XX_HW_82C929:
> > 		strcpy(card->mixername, "ACI & OPTi929");
> > 	default:
> > 		strcpy(card->mixername, "ACI & OPTi9xx");
> > 	}
> 
> The default case cannot happen (bwahaha!), so it might make sense to
> put a snd_BUG() in there.

good point. fixed.

> > - OPL4 support is still missing, because I'm still waiting for response
> > of my broken OPL4 chip. :(
> 
> Is it broken with the snd-opti92x-cs4231 driver, too?

Yep, it's even broken with Win2000. 

> > - I never saw any docs about the cards. All knowledge is taken from ACI
> > driver (OSS) and OPTi9xx (ALSA) drivers.
> 
> There are OPTi manuals on the ALSA FTP server.

I wasn't precise here. I was looking for ACI or Miro specific documents. 
E.g. the OSS driver has no real equalizer implementation. I hope it's 
handled correct now, because it's still untested PCM20 stuff.
OTOH, I haven't had a hole of knowledge in the OPTi part. There was no 
reason for looking into the OPTi specifications, the ALSA opti driver 
had all things inside (at least for me).

BTW, I just asked google and I've found two other intersting documents 
for addition to the ALSA ftp area:

Opti929:
http://ftp.cis.nctu.edu.tw/data/Multimedia/SoundCard/OPTi/82c929/db013_10.pdf

OPL4:
http://ftp.funet.fi/pub/msx/docs/datasheets/opl4.pdf


bye,
martin

[-- Attachment #2: miro-0.6.patch.bz2 --]
[-- Type: application/octet-stream, Size: 8911 bytes --]