From: Matt Mackall <mpm@selenic.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Alexander Nyberg <alexn@dsv.su.se>,
jgarzik@pobox.com, netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: Reproducible panics with tulip
Date: Fri, 18 Mar 2005 19:13:21 -0800 [thread overview]
Message-ID: <20050319031321.GA25554@waste.org> (raw)
In-Reply-To: <20050318223939.GB24509@electric-eye.fr.zoreil.com>
On Fri, Mar 18, 2005 at 11:39:39PM +0100, Francois Romieu wrote:
>
> zap_completion_queue can be called in any context through netpoll_send_udp.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
>
> diff -puN net/core/netpoll.c~netconsole-000 net/core/netpoll.c
> --- a/net/core/netpoll.c~netconsole-000 2005-03-18 23:29:28.499641348 +0100
> +++ b/net/core/netpoll.c 2005-03-18 23:33:13.856959994 +0100
> @@ -142,7 +142,7 @@ static void zap_completion_queue(void)
> while (clist != NULL) {
> struct sk_buff *skb = clist;
> clist = clist->next;
> - __kfree_skb(skb);
> + dev_kfree_skb_any(skb);
> }
> }
Please, cc: me on such things. I sent this fix a while back, but DaveM
never acked it.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-03-19 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-18 20:36 Reproducible panics with tulip Alexander Nyberg
2005-03-18 21:52 ` Francois Romieu
2005-03-18 22:39 ` Francois Romieu
2005-03-19 3:13 ` Matt Mackall [this message]
2005-03-19 3:47 ` David S. Miller
2005-03-19 11:29 ` Alexander Nyberg
2005-03-19 9:21 ` Alexander Nyberg
2005-03-19 10:20 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319031321.GA25554@waste.org \
--to=mpm@selenic.com \
--cc=alexn@dsv.su.se \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.