All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@mail.ru>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: domen@coderock.org, davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/4] crypto/sha256.c: fix sparse warnings
Date: Sun, 20 Mar 2005 11:10:39 +0300	[thread overview]
Message-ID: <200503201110.39174.adobriyan@mail.ru> (raw)
In-Reply-To: <E1DCuuz-0003fC-00@gondolin.me.apana.org.au>

On Sunday 20 March 2005 10:32, Herbert Xu wrote:
> domen@coderock.org wrote:
> > +++ kj-domen/crypto/sha256.c

> > static inline void LOAD_OP(int I, u32 *W, const u8 *input)
> > {
> > -       W[I] = __be32_to_cpu( ((u32*)(input))[I] );
> > +       W[I] = __be32_to_cpu( ((__be32*)(input))[I] );
>
> I don't get any warnings here (sparse version dated 12/03/2005).
> What warnings are you getting exactly?

crypto/sha256.c:61:9: warning: cast to restricted type

Use CHECK="sparse -Wbitwise" to see it.

 Alexey

  reply	other threads:[~2005-03-20  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-19 13:18 [patch 1/4] crypto/sha256.c: fix sparse warnings domen
2005-03-20  7:32 ` Herbert Xu
2005-03-20  8:10   ` Alexey Dobriyan [this message]
2005-03-20  9:39     ` Herbert Xu
2005-03-20 11:19 ` [patch 1/4 with proper signed-off] " Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503201110.39174.adobriyan@mail.ru \
    --to=adobriyan@mail.ru \
    --cc=davem@davemloft.net \
    --cc=domen@coderock.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.