Re: [Qemu-devel] make stdio monitor default

[Paul Brook <paul@codesourcery.com>]

> I agree that vc should be the default for Windows, but that for Linux (and
> Unix) having stdio default would be better. (This is of course a policy
> decision, not a coding or feature one, as both stdio and vc can be used in
> either Linux or Windows host). It would be nice to get other opinions on 
> this. 

I agree, although I think the proper fix is to move the logic into the 
configure script and make it a configure time option. 
ie ./configure --enable-monitor=foo would set the default.

> --- vl.c.old Fri Mar 18 23:01:24 2005
> +++ vl.c Fri Mar 18 23:02:03 2005
> @@ -3031,7 +3031,11 @@
>      has_cdrom = 1;
>      cyls = heads = secs = 0;
>      translation = BIOS_ATA_TRANSLATION_AUTO;
> +#ifndef _WIN32
>      pstrcpy(monitor_device, sizeof(monitor_device), "vc");
> +#else
> +    pstrcpy(monitor_device, sizeof(monitor_device), "stdio");
> +#endif
>  
>      pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc");
>      for(i = 1; i < MAX_SERIAL_PORTS; i++)

Have you tested this patch? It looks like it does the opposite of what you are 
suggesting.

Paul