From mboxrd@z Thu Jan 1 00:00:00 1970 From: Domen Puncer Subject: Re: [patch 3/6 with proper signed-off] fs/ext3/super.c: fix sparse warnings Date: Sun, 20 Mar 2005 12:53:59 +0100 Message-ID: <20050320115359.GN14273@nd47.coderock.org> References: <20050319131832.4E6501F23D@trashy.coderock.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, adobriyan@mail.ru Received: from coderock.org ([193.77.147.115]:54667 "EHLO trashy.coderock.org") by vger.kernel.org with ESMTP id S262140AbVCTLyE (ORCPT ); Sun, 20 Mar 2005 06:54:04 -0500 To: viro@parcelfarce.linux.theplanet.co.uk Content-Disposition: inline In-Reply-To: <20050319131832.4E6501F23D@trashy.coderock.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Signed-off-by: Alexey Dobriyan Signed-off-by: Domen Puncer --- kj-domen/fs/ext3/super.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN fs/ext3/super.c~sparse-fs_ext3_super fs/ext3/super.c --- kj/fs/ext3/super.c~sparse-fs_ext3_super 2005-03-20 12:11:26.000000000 +0100 +++ kj-domen/fs/ext3/super.c 2005-03-20 12:11:27.000000000 +0100 @@ -2106,6 +2106,7 @@ static int ext3_remount (struct super_bl ext3_mark_recovery_complete(sb, es); } else { __le32 ret; + int ret1; if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP))) { printk(KERN_WARNING "EXT3-fs: %s: couldn't " @@ -2122,8 +2123,8 @@ static int ext3_remount (struct super_bl */ ext3_clear_journal_err(sb, es); sbi->s_mount_state = le16_to_cpu(es->s_state); - if ((ret = ext3_group_extend(sb, es, n_blocks_count))) - return ret; + if ((ret1 = ext3_group_extend(sb, es, n_blocks_count))) + return ret1; if (!ext3_setup_super (sb, es, 0)) sb->s_flags &= ~MS_RDONLY; } _