From mboxrd@z Thu Jan 1 00:00:00 1970 From: Domen Puncer Subject: Re: [patch 5/6 with proper signed-off] fs/hpfs/inode.c: fix sparse warnings Date: Sun, 20 Mar 2005 12:55:04 +0100 Message-ID: <20050320115504.GP14273@nd47.coderock.org> References: <20050319131838.5378C1ECA8@trashy.coderock.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, adobriyan@mail.ru Received: from coderock.org ([193.77.147.115]:58251 "EHLO trashy.coderock.org") by vger.kernel.org with ESMTP id S262144AbVCTLzK (ORCPT ); Sun, 20 Mar 2005 06:55:10 -0500 To: viro@parcelfarce.linux.theplanet.co.uk Content-Disposition: inline In-Reply-To: <20050319131838.5378C1ECA8@trashy.coderock.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Signed-off-by: Alexey Dobriyan Signed-off-by: Domen Puncer --- kj-domen/fs/hpfs/inode.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff -puN fs/hpfs/inode.c~sparse-fs_hpfs_inode fs/hpfs/inode.c --- kj/fs/hpfs/inode.c~sparse-fs_hpfs_inode 2005-03-20 12:11:28.000000000 +0100 +++ kj-domen/fs/hpfs/inode.c 2005-03-20 12:11:28.000000000 +0100 @@ -61,14 +61,14 @@ void hpfs_read_inode(struct inode *i) if (hpfs_sb(i->i_sb)->sb_eas) { if ((ea = hpfs_get_ea(i->i_sb, fnode, "UID", &ea_size))) { if (ea_size == 2) { - i->i_uid = le16_to_cpu(*(u16*)ea); + i->i_uid = le16_to_cpup((__le16*)ea); hpfs_inode->i_ea_uid = 1; } kfree(ea); } if ((ea = hpfs_get_ea(i->i_sb, fnode, "GID", &ea_size))) { if (ea_size == 2) { - i->i_gid = le16_to_cpu(*(u16*)ea); + i->i_gid = le16_to_cpup((__le16*)ea); hpfs_inode->i_ea_gid = 1; } kfree(ea); @@ -88,7 +88,7 @@ void hpfs_read_inode(struct inode *i) int rdev = 0; umode_t mode = hpfs_sb(sb)->sb_mode; if (ea_size == 2) { - mode = le16_to_cpu(*(u16*)ea); + mode = le16_to_cpup((__le16*)ea); hpfs_inode->i_ea_mode = 1; } kfree(ea); @@ -96,7 +96,7 @@ void hpfs_read_inode(struct inode *i) if (S_ISBLK(mode) || S_ISCHR(mode)) { if ((ea = hpfs_get_ea(i->i_sb, fnode, "DEV", &ea_size))) { if (ea_size == 4) - rdev = le32_to_cpu(*(u32*)ea); + rdev = le32_to_cpup((__le32*)ea); kfree(ea); } } @@ -149,7 +149,7 @@ static void hpfs_write_inode_ea(struct i we'd better not overwrite them hpfs_error(i->i_sb, "fnode %08x has some unknown HPFS386 stuctures", i->i_ino); } else*/ if (hpfs_sb(i->i_sb)->sb_eas >= 2) { - u32 ea; + __le32 ea; if ((i->i_uid != hpfs_sb(i->i_sb)->sb_uid) || hpfs_inode->i_ea_uid) { ea = cpu_to_le32(i->i_uid); hpfs_set_ea(i, fnode, "UID", (char*)&ea, 2); _