From: "Jim C. Brown" <jma5@umd.edu>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] make stdio monitor default
Date: Sun, 20 Mar 2005 14:56:08 -0500 [thread overview]
Message-ID: <20050320195608.GA11155@jbrown.mylinuxbox.org> (raw)
In-Reply-To: <200503201126.13115.paul@codesourcery.com>
On Sun, Mar 20, 2005 at 11:26:12AM +0000, Paul Brook wrote:
> Have you tested this patch? It looks like it does the opposite of what you are
> suggesting.
>
> Paul
>
>
Whoops I sent the wrong one. Here is the right version:
--- vl.c.old Fri Mar 18 23:01:24 2005
+++ vl.c Fri Mar 18 23:02:03 2005
@@ -3031,7 +3031,11 @@
has_cdrom = 1;
cyls = heads = secs = 0;
translation = BIOS_ATA_TRANSLATION_AUTO;
+#ifdef _WIN32
pstrcpy(monitor_device, sizeof(monitor_device), "vc");
+#else
+ pstrcpy(monitor_device, sizeof(monitor_device), "stdio");
+#endif
pstrcpy(serial_devices[0], sizeof(serial_devices[0]), "vc");
for(i = 1; i < MAX_SERIAL_PORTS; i++)
> I agree, although I think the proper fix is to move the logic into the
> configure script and make it a configure time option.
> ie ./configure --enable-monitor=foo would set the default.
Interesting idea. I'll see if I can set this up and send a diff.
--
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.
prev parent reply other threads:[~2005-03-20 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 4:17 [Qemu-devel] make stdio monitor default Jim C. Brown
2005-03-20 11:26 ` Paul Brook
2005-03-20 19:56 ` Jim C. Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050320195608.GA11155@jbrown.mylinuxbox.org \
--to=jma5@umd.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.