From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@oss.sgi.com, Patrick McHardy <kaber@trash.net>
Subject: Re: patch: introduce simple actions
Date: Sun, 20 Mar 2005 21:18:36 +0100 [thread overview]
Message-ID: <20050320201836.GW3086@postel.suug.ch> (raw)
In-Reply-To: <1111349426.1092.128.camel@jzny.localdomain>
> > > +
> > > +struct tc_defact
> > > +{
> > > + tc_gen;
> > > +};
> >
> > tcf_defact, tc_defact, .. quite easy to get this wrong. Maybe
> > it would a good idea to rename tcf_defact to tcf_defact_parm?
> >
>
> sigh. another LinuxWay(tm). Unfortunately this is all over the net/sched
> code to imply something thats user specific vs kernel specific. If
> you feel strongly about it i will change it - otherwise maybe we can
> leave it till some day some brave person will clean up the whole thing?
Yes I know and I don't feel that strong about it. I just tend to dislike
it a tiny bit, I do like the struct rta_kern style better. Let's wait for
the brave knight to appear someday.
prev parent reply other threads:[~2005-03-20 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-20 19:05 patch: introduce simple actions Jamal Hadi Salim
2005-03-20 19:22 ` Patrick McHardy
2005-03-20 19:35 ` Jamal Hadi Salim
2005-03-20 19:58 ` Patrick McHardy
2005-03-20 20:17 ` Jamal Hadi Salim
2005-03-20 20:31 ` Thomas Graf
2005-03-20 20:41 ` jamal
2005-03-23 2:27 ` Patrick McHardy
2005-03-23 3:58 ` David S. Miller
2005-03-23 4:06 ` Jamal Hadi Salim
2005-04-06 13:29 ` PATCH: Allow Simple actions WAS(Re: " jamal
2005-04-25 3:10 ` David S. Miller
2005-03-20 19:44 ` Thomas Graf
2005-03-20 20:10 ` jamal
2005-03-20 20:18 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050320201836.GW3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.