All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Jesper Juhl <juhl-lkml@dif.dk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Antonino Daplas <adaplas@pol.net>,
	linux-fbdev-devel@lists.sourceforge.net,
	Alex Kern <alex.kern@gmx.de>,
	Ani Joshi <ajoshi@shell.unixbox.com>,
	"Ben. Herrenschmidt" <benh@kernel.crashing.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Helge Deller <deller@gmx.de>, Philipp Rumpf <prumpf@tux.org>,
	James Simmons <jsimmons@users.sf.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"Eddie C. Dost" <ecd@skynet.be>, Nicolas Pitre <nico@cam.org>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] remove redundant NULL checks before kfree() in drivers/video/
Date: Mon, 21 Mar 2005 04:53:47 +0800	[thread overview]
Message-ID: <200503210453.47487.adaplas@hotpop.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0503192339190.5507@dragon.hyggekrogen.localhost>

On Sunday 20 March 2005 06:59, Jesper Juhl wrote:
> Checking a pointer for NULL before calling kfree() on it is redundant,
> kfree() deals with NULL pointers just fine.
> This patch removes such checks from files in drivers/video/
>
> Since this is a fairly trivial change (and the same change made
> everywhere) I've just made a single patch for all the files and CC all
> authors/maintainers of those files I could find for comments. If spliting
> this into one patch pr file is prefered, then I can easily do that as
> well.
>

[snip]

> --- linux-2.6.11-mm4-orig/drivers/video/console/bitblit.c	2005-03-16
> 15:45:26.000000000 +0100 +++
> linux-2.6.11-mm4/drivers/video/console/bitblit.c	2005-03-19
> 22:27:39.000000000 +0100 @@ -199,8 +199,7 @@ static void bit_putcs(struct
> vc_data *vc
>  		count -= cnt;
>  	}
>
> -	if (buf)
> -		kfree(buf);
> +	kfree(buf);
>  }
>

This is performance critical, so I would like the check to remain. A comment
may be added in this section.

>  static void bit_clear_margins(struct vc_data *vc, struct fb_info *info,
> @@ -273,8 +272,7 @@ static void bit_cursor(struct vc_data *v
>  		dst = kmalloc(w * vc->vc_font.height, GFP_ATOMIC);
>  		if (!dst)
>  			return;
> -		if (ops->cursor_data)
> -			kfree(ops->cursor_data);
> +		kfree(ops->cursor_data);
>  		ops->cursor_data = dst;
>  		update_attr(dst, src, attribute, vc);
>  		src = dst;
> @@ -321,8 +319,7 @@ static void bit_cursor(struct vc_data *v
>  		if (!mask)
>  			return;
>
> -		if (ops->cursor_state.mask)
> -			kfree(ops->cursor_state.mask);
> +		kfree(ops->cursor_state.mask);
>  		ops->cursor_state.mask = mask;

Although these are also performance critical, I will agree that the checks
can go.  Very rarely will ops->cursor_state.mask and ops->cursor_data be
NULL.

As for the rest, they are acceptable, as long as the maintainers agree.

Tony



  reply	other threads:[~2005-03-20 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-19 22:59 [PATCH] remove redundant NULL checks before kfree() in drivers/video/ Jesper Juhl
2005-03-20 20:53 ` Antonino A. Daplas [this message]
2005-03-20 21:49   ` Geert Uytterhoeven
2005-03-20 22:18     ` Antonino A. Daplas
2005-03-20 22:01   ` Jan Engelhardt
2005-03-20 22:02   ` Jesper Juhl
2005-03-20 22:17     ` Antonino A. Daplas
2005-03-20 22:29       ` Jesper Juhl
2005-03-20 22:45         ` [new patch] Re: [PATCH] remove redundant NULL checks before kfree() in drivers/video/w100fb.c and add if()+comment back in drivers/video/console/bitblit.c Jesper Juhl
2005-03-20 23:04           ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503210453.47487.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=adaplas@pol.net \
    --cc=ajoshi@shell.unixbox.com \
    --cc=akpm@osdl.org \
    --cc=alex.kern@gmx.de \
    --cc=benh@kernel.crashing.org \
    --cc=deller@gmx.de \
    --cc=ecd@skynet.be \
    --cc=geert@linux-m68k.org \
    --cc=jsimmons@users.sf.net \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=prumpf@tux.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.