From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Frank Sorenson <frank@tuxrocks.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Valdis.Kletnieks@vt.edu
Subject: Re: [PATCH 0/5] I8K driver facelift
Date: Mon, 21 Mar 2005 18:55:43 -0500 [thread overview]
Message-ID: <200503211855.43537.dtor_core@ameritech.net> (raw)
In-Reply-To: <423F507B.1090009@tuxrocks.com>
On Monday 21 March 2005 17:53, Frank Sorenson wrote:
> Dmitry Torokhov wrote:
> > I have implemented arrays of groups of attributes:
>
> Works great here. The i8k-cumulative patch claimed to be malformed, but
> I merged it in just fine by hand. In arch/i386/kernel/dmi_scan.c, I had
> to EXPORT dmi_get_system_info in order to get the i8k module to load.
> That may have been a mistake on my end (lots of odd patches in my tree
> right now).
No, I bet I forgot to export it - I have i8k compiled in and would not
notice missing export.
> I'm a little curious to see how many people are going to
> find they need the ignore_dmi flag versus working without it.
I want this driver to be first of all safe for loading on a random box
so it can be enabled by default.
>
> Everything works great, and it is a big step up from the existing code.
> I say lets go with it.
>
Yep, I will add missing export and forward it to Andrew - it could use
some time in -mm.
Thank you very much for testing it.
--
Dmitry
next prev parent reply other threads:[~2005-03-22 0:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 6:10 [PATCH 0/5] I8K driver facelift Dmitry Torokhov
2005-02-24 6:11 ` [PATCH 1/5] I8K - pass though Lindent Dmitry Torokhov
2005-02-24 6:12 ` [PATCH 2/5] I8K - use standard DMI functions Dmitry Torokhov
2005-02-24 6:12 ` [PATCH 3/5] I8K - switch to seq_file Dmitry Torokhov
2005-02-24 6:14 ` [PATCH 4/5] I8K - switch to module_{init|exit} Dmitry Torokhov
2005-02-24 6:14 ` [PATCH 5/5] I8K - convert to platform device (sysfs) Dmitry Torokhov
2005-03-13 3:41 ` [PATCH 0/5] I8K driver facelift Frank Sorenson
2005-03-13 3:59 ` Dmitry Torokhov
2005-03-15 8:12 ` Valdis.Kletnieks
2005-03-15 10:59 ` Giuseppe Bilotta
2005-03-15 17:30 ` Valdis.Kletnieks
2005-03-15 22:34 ` Frank Sorenson
2005-03-16 21:38 ` Frank Sorenson
2005-03-17 6:40 ` Dmitry Torokhov
2005-03-17 9:37 ` Frank Sorenson
2005-03-17 15:05 ` Dmitry Torokhov
2005-03-17 9:46 ` Frank Sorenson
2005-03-21 5:12 ` Dmitry Torokhov
2005-03-21 22:53 ` Frank Sorenson
2005-03-21 23:55 ` Dmitry Torokhov [this message]
2005-03-24 7:25 ` Greg KH
2005-03-24 7:39 ` Dmitry Torokhov
2005-03-24 8:00 ` Greg KH
2005-03-24 14:44 ` Dmitry Torokhov
2005-03-17 8:16 ` Valdis.Kletnieks
2005-03-24 7:24 ` Greg KH
2005-04-13 6:33 ` Dmitry Torokhov
2005-04-13 8:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503211855.43537.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=frank@tuxrocks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.