From: Vicente Feito <vicente.feito@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ][PATCH] kj-devel.pl - diff -u
Date: Tue, 22 Mar 2005 11:25:28 +0000 [thread overview]
Message-ID: <200503221125.28549.vicente.feito@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 36 bytes --]
here's the diff -u patch
Vicente.
[-- Attachment #2: kj-devel.patch --]
[-- Type: text/x-diff, Size: 2572 bytes --]
--- ../kj-devel.pl.orig 2005-03-22 00:05:01.000000000 +0000
+++ kj-devel.pl 2005-03-22 09:21:41.000000000 +0000
@@ -253,8 +253,8 @@
if (not exists($locks{$2}) or
(exists($locks{$2}) and @{$locks{$2}} == 0)) {
- print "Unlocking a lock that hasn't been aquired ".
- "yet(could be a false positive) - Line:$linenr\n\n";
+ print "Unlocking a lock that hasn't been acquired ".
+ "yet (could be a false positive) - Line:$linenr\n\n";
} else {
#get rid of the last one
pop @{$locks{$2}};
@@ -269,8 +269,8 @@
if (not exists($locks_irq{$2}) or
(exists($locks_irq{$2}) and @{$locks_irq{$2}} == 0)) {
- print "Unlocking a lock that hasn't been aquired ".
- "yet(could be a false positive) - Line:$linenr\n\n";
+ print "Unlocking a lock that hasn't been acquired ".
+ "yet (could be a false positive) - Line:$linenr\n\n";
} else {
pop @{$locks_irq{$2}};
}
@@ -284,8 +284,8 @@
if (not exists($locks_bh{$2}) or
(exists($locks_bh{$2}) and @{$locks_bh{$2}} == 0)) {
- print "Unlocking a lock that hasn't been aquired ".
- "yet(could be a false positive) - Line:$linenr\n\n";
+ print "Unlocking a lock that hasn't been acquired ".
+ "yet (could be a false positive) - Line:$linenr\n\n";
} else {
pop @{$locks_bh{$2}};
}
@@ -299,7 +299,7 @@
if (not exists($ioremap{$2}) or
(exists($ioremap{$2}) and @{$ioremap{$2}} == 0)) {
print "Unmapping a region that hasn't been mapped ".
- "yet(could be a false positive) - Line:$linenr\n\n";
+ "yet (could be a false positive) - Line:$linenr\n\n";
} else {
pop @{$ioremap{$2}};
}
@@ -344,7 +344,11 @@
print "$filename:$linenr:$line\n\n";
}
if ($line=~/(const )?char ?\* ?\w+ ?= ?\".*\"/) {
- print "Using foo[] it's recommended over *foo: saves memory references & code\n";
+ print "Using foo[] is recommended over *foo: saves memory references & code\n";
+ print "$filename:$linenr:$line\n\n";
+ }
+ if ($line=~/memset\((.*),( *sizeof.*),( *\d+)\)/) {
+ print "Your memset parameters appears to be backwards\n";
print "$filename:$linenr:$line\n\n";
}
$linenr++;
@@ -356,7 +360,7 @@
show_balance_results(1,%ioremap);
if (!$nomodules and !defined($module)) {
- print "If you're building a module, be concious that you must use the".
+ print "If you're building a module, note that you must use the".
" init mechanism, module_init() and module_exit().\n";
}
if (!$nomodules and $drvdata) {
[-- Attachment #3: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-03-22 11:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503221125.28549.vicente.feito@gmail.com \
--to=vicente.feito@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.