All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	'Holger Kiehl' <Holger.Kiehl@dwd.de>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, "Moore, Eric  Dean" <emoore@lsil.com>
Subject: Re: Fusion-MPT much faster as module
Date: Tue, 22 Mar 2005 13:28:01 +0100	[thread overview]
Message-ID: <20050322122801.GI3982@stusta.de> (raw)
In-Reply-To: <1111488742.7096.61.camel@laptopd505.fenrus.org>

On Tue, Mar 22, 2005 at 11:52:22AM +0100, Arjan van de Ven wrote:
> On Tue, 2005-03-22 at 02:29 -0800, Chen, Kenneth W wrote:
> 
> > Before:
> > /dev/sdc:
> >  Timing buffered disk reads:   92 MB in  3.03 seconds =  30.32 MB/sec
> > 
> > After:
> > /dev/sdc:
> >  Timing buffered disk reads:  174 MB in  3.02 seconds =  57.61 MB/sec
> 
> 
> nice!
> 
> More proof that #ifdef MODULE is considered harmful... how much of it is
> actually left in the kernel? Maybe we could kill it entirely from
> drivers/*  (of course it has a limited place in include/*)

Too many...

And there are places where it's actually useful:

  #if defined(CONFIG_FOO) || (defined(MODULE) && defined(CONFIG_FOO_MODULE))

is a good way to express that driver bar can use functionality of driver 
foo if it's available.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-03-22 12:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-08 13:38 Fusion-MPT much faster as module Holger Kiehl
2005-03-21 23:27 ` Andrew Morton
2005-03-22  7:32   ` Janne Pikkarainen
2005-03-22  8:31   ` Holger Kiehl
2005-03-22 10:29     ` Chen, Kenneth W
2005-03-22 10:29       ` Chen, Kenneth W
2005-03-22 10:42       ` Andrew Morton
2005-03-22 10:52       ` Arjan van de Ven
2005-03-22 12:28         ` Adrian Bunk [this message]
2005-03-22 12:37           ` Arjan van de Ven
2005-03-22 19:36           ` Fusion-MPT much faster as module - ifdef MODULE considered harmful Bryan Henderson
2005-03-22 13:46       ` Fusion-MPT much faster as module Holger Kiehl
  -- strict thread matches above, loose matches on Subject: below --
2005-03-21 23:46 Moore, Eric Dean
2005-03-31 18:59 ` augustus
2005-03-31 20:22   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050322122801.GI3982@stusta.de \
    --to=bunk@stusta.de \
    --cc=Holger.Kiehl@dwd.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=emoore@lsil.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.