All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Feito <vicente.feito@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.12-rc1-mm1] net/ethernet/eth.c - eth_header
Date: Tue, 22 Mar 2005 13:38:08 +0000	[thread overview]
Message-ID: <200503221338.08834.vicente.feito@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi,
Please consider applying (or droping).
Thank you.

Description: This patch prevent drivers from calling eth_header with a 802.3 
frame using a len>1536. In such a case returns -EINVAL, which was hard to 
choose because the ETH_HLEN is supposed to return.

Signed-off-by: Vicente Feito <vicente.feito@gmail.com>

[-- Attachment #2: eth.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]

--- linux-2.6.12-rc1-mm1/net/ethernet/eth.c.orig	2005-03-22 12:49:08.000000000 +0000
+++ linux-2.6.12-rc1-mm1/net/ethernet/eth.c	2005-03-22 12:49:36.000000000 +0000
@@ -78,6 +78,8 @@ int eth_header(struct sk_buff *skb, stru
 {
 	struct ethhdr *eth = (struct ethhdr *)skb_push(skb,ETH_HLEN);
 
+	if (type == ETH_P_802_3 && len >= 1536)
+		return -EINVAL;
 	/* 
 	 *	Set the protocol type. For a packet of type ETH_P_802_3 we put the length
 	 *	in here instead. It is up to the 802.2 layer to carry protocol information.

             reply	other threads:[~2005-03-22 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-22 13:38 Vicente Feito [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-03-23 17:34 [PATCH 2.6.12-rc1-mm1] net/ethernet/eth.c - eth_header Vicente Feito
2005-03-23 20:50 ` Jeff Garzik
2005-03-23 18:15   ` Vicente Feito
2005-03-23 21:25     ` Jon Mason
2005-03-23 20:52 ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503221338.08834.vicente.feito@gmail.com \
    --to=vicente.feito@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.