From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1DE1yH-00079w-AW for user-mode-linux-devel@lists.sourceforge.net; Wed, 23 Mar 2005 01:16:13 -0800 Received: from dsl092-053-140.phl1.dsl.speakeasy.net ([66.92.53.140] helo=grelber.thyrsus.com) by sc8-sf-mx2.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.41) id 1DE1y1-0008Fq-JA for user-mode-linux-devel@lists.sourceforge.net; Wed, 23 Mar 2005 01:16:13 -0800 From: Rob Landley Subject: Re: [uml-devel] Hostfs permission checks are all wonky. References: <200503201417.59739.rob@landley.net> <200503222019.10709.blaisorblade@yahoo.it> In-Reply-To: <200503222019.10709.blaisorblade@yahoo.it> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200503230313.06299.rob@landley.net> Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Wed, 23 Mar 2005 03:13:04 -0500 To: user-mode-linux-devel@lists.sourceforge.net Cc: Blaisorblade On Tuesday 22 March 2005 02:19 pm, Blaisorblade wrote: > Ok, I'm now seeing that UML uses access() (inside access_file()) to check > permissions. > > See hostfs_permission -> access_file -> access. hostfs_permission (not > access_file) should skip the "access_file" call in case its type is > OS_TYPE_CHARDEV / OS_TYPE_BLOCKDEV / OS_TYPE_FIFO / OS_TYPE_SOCK. > > Look at init_inode() about how to see the file's type, but even better look > at the cached information, i.e. inode->i_mode and the S_* access macro > (look at init_special_inode about this). Just confirming: this patch fixed it. Both /dev/loop0 and /dev/console work just fine with hostfs root now. Can this patch make it into 2.6.12? Rob ------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel