Re: [PATCH] Jazzsonic driver updates

[Ralf Baechle <ralf@linux-mips.org>]

On Tue, Mar 22, 2005 at 06:13:17PM +0100, Geert Uytterhoeven wrote:

> On Fri, 28 Jan 2005, Linux Kernel Mailing List wrote:
> > ChangeSet 1.1986, 2005/01/28 00:12:28-05:00, ralf@linux-mips.org
> > 
> > 	[PATCH] Jazzsonic driver updates
> > 	
> > 	 o Resurrect the Jazz SONIC driver after years of it not having been tested
> > 	 o Convert from Space.c initialization to module_init / platform device.
> > 	
> > 	Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
> 
> > --- a/drivers/net/sonic.c	2005-03-06 18:10:39 -08:00
> > +++ b/drivers/net/sonic.c	2005-03-06 18:10:39 -08:00
> > @@ -116,7 +116,7 @@
> >  	/*
> >  	 * Map the packet data into the logical DMA address space
> >  	 */
> > -	if ((laddr = vdma_alloc(PHYSADDR(skb->data), skb->len)) == ~0UL) {
> > +	if ((laddr = vdma_alloc(CPHYSADDR(skb->data), skb->len)) == ~0UL) {
>                                 ^^^^^^^^^
> This part broke compilation for Mac/m68k.
> 
> >  		printk("%s: no VDMA entry for transmit available.\n",
> >  		       dev->name);
> >  		dev_kfree_skb(skb);

Oh funny.  vdma_alloc() was created 10 years ago as an internal API for
the Jazz machines.  Didn't realize m68k had cloned it :-)  If anything
it seems this should be converted to the modern DMA API.

  Ralf