From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Yichen Xie <yxie@cs.stanford.edu>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
"David S. Miller" <davem@davemloft.net>,
kaber@trash.net
Subject: Re: memory leak in net/sched/ipt.c?
Date: Wed, 23 Mar 2005 13:55:16 +0100 [thread overview]
Message-ID: <20050323125516.GP3086@postel.suug.ch> (raw)
In-Reply-To: <1111581618.1088.72.camel@jzny.localdomain>
* jamal <1111581618.1088.72.camel@jzny.localdomain> 2005-03-23 07:40
> On Wed, 2005-03-23 at 06:30, Herbert Xu wrote:
> > Yichen Xie <yxie@cs.stanford.edu> wrote:
> > > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump
> > > is called?
> >
> > It seems to be. This patch should free it.
> >
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Just a small correction to patchlet:
> The second kfree should check for existence of t.
t is either valid or NULL so it's not a problem, unless you want
to create janitor work of course. ;->
next prev parent reply other threads:[~2005-03-23 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 8:13 memory leak in net/sched/ipt.c? Yichen Xie
2005-03-23 8:48 ` Jan Engelhardt
2005-03-23 11:30 ` Herbert Xu
2005-03-23 12:40 ` jamal
2005-03-23 12:55 ` Thomas Graf [this message]
2005-03-23 13:11 ` jamal
2005-03-23 13:23 ` Thomas Graf
2005-03-23 13:32 ` jamal
2005-03-23 13:40 ` Jan Engelhardt
2005-03-23 14:05 ` jamal
2005-03-23 14:12 ` jamal
2005-03-23 13:03 ` Jan Engelhardt
2005-03-23 18:27 ` Yichen Xie
2005-03-23 19:01 ` Jan Engelhardt
2005-03-23 19:07 ` Randy.Dunlap
2005-03-23 20:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050323125516.GP3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=yxie@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.