All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: urban@teststation.com
Cc: samba@samba.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] fs/smbfs/request.c: fix NULL dereference
Date: Fri, 25 Mar 2005 01:15:40 +0100	[thread overview]
Message-ID: <20050325001540.GF3966@stusta.de> (raw)

The Coverity checker found that if req was NULL because find_request 
returned NULL, this resulted in a break from the switch, but req was 
later dereferenced (look at the last line of this patch).

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-rc1-mm2-full/fs/smbfs/request.c.old	2005-03-25 00:45:08.000000000 +0100
+++ linux-2.6.12-rc1-mm2-full/fs/smbfs/request.c	2005-03-25 00:47:14.000000000 +0100
@@ -783,20 +783,23 @@ int smb_request_recv(struct smb_sb_info 
 			break;
 		break;
 
 		/* We should never be called with any of these states */
 	case SMB_RECV_END:
 	case SMB_RECV_REQUEST:
 		server->rstate = SMB_RECV_END;
 		break;
 	}
 
+	if (!req)
+		return -ENOMEM;
+
 	if (result < 0) {
 		/* We saw an error */
 		return result;
 	}
 
 	if (server->rstate != SMB_RECV_END)
 		return 0;
 
 	result = 0;
 	if (req->rq_trans2_command && req->rq_rcls == SUCCESS)


             reply	other threads:[~2005-03-25  2:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25  0:15 Adrian Bunk [this message]
2005-03-26  9:02 ` [2.6 patch] fs/smbfs/request.c: fix NULL dereference Jean Delvare
2005-03-26 12:53   ` [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG() Adrian Bunk
2005-03-26 13:11     ` Adrian Bunk
2005-03-26 18:16       ` Jean Delvare
2005-04-09  8:47       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050325001540.GF3966@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samba@samba.org \
    --cc=urban@teststation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.