From: "David S. Miller" <davem@davemloft.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch] xfrm_policy destructor fix
Date: Fri, 25 Mar 2005 09:28:13 -0800 [thread overview]
Message-ID: <20050325092813.20e00ef9.davem@davemloft.net> (raw)
In-Reply-To: <20050325143440.GA4516@elte.hu>
On Fri, 25 Mar 2005 15:34:41 +0100
Ingo Molnar <mingo@elte.hu> wrote:
> the patch below fixes a bug that i encountered while running a
> PREEMPT_RT kernel, but i believe it should be fixed in the generic
> kernel too. xfrm_policy_kill() queues a destroyed policy structure to
> the GC list, and unlocks the policy->lock spinlock _after_ that point.
> This created a scenario where GC processing got to the new structure
> first, and kfree()d it - then the write_unlock_bh() was done on the
> already kfreed structure. There is no guarantee that GC processing will
> be done after policy->lock has been dropped and softirq processing has
> been enabled.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Good catch Ingo, patch applied. Thanks.
next prev parent reply other threads:[~2005-03-25 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 14:34 [patch] xfrm_policy destructor fix Ingo Molnar
2005-03-25 17:28 ` David S. Miller [this message]
2005-03-26 1:11 ` Herbert Xu
2005-04-01 6:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325092813.20e00ef9.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.