From: "Scott M. Ferris" <sferris@acm.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: "Scott M. Ferris" <sferris@acm.org>, netdev@oss.sgi.com
Subject: Re: TSO prevents cwnd growth on 2.6 kernels
Date: Fri, 25 Mar 2005 13:34:59 -0600 [thread overview]
Message-ID: <20050325193458.GA15645@visi.com> (raw)
In-Reply-To: <20050325104000.713229be.davem@davemloft.net>
On Fri, Mar 25, 2005 at 10:40:00AM -0800, David S. Miller wrote:
>
> We know it's busted. I haven't gotten to fixing this stuff
> up yet.
Perhaps TSO should default to off for all drivers then? I hadn't even
noticed it was enabled until after I was debugging the problem.
> Are you suggesting to let it go past tp->snd_cwnd? We can't
> ever do that. tp->snd_cwnd is a hard limit on the number
> of frames we may have outstanding on the network at one time,
> TSO or not.
No, I think we all agree that exceeding cwnd is a bad idea. I'm just
saying that failing to reach cwnd is also broken, especially if it
results in tcp_write_xmit() sending nothing at all when cwnd is small.
--
Scott M. Ferris,
sferris@acm.org
next prev parent reply other threads:[~2005-03-25 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 18:18 TSO prevents cwnd growth on 2.6 kernels Scott M. Ferris
2005-03-25 18:40 ` David S. Miller
2005-03-25 19:34 ` Scott M. Ferris [this message]
2005-03-25 19:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325193458.GA15645@visi.com \
--to=sferris@acm.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.