All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@oss.sgi.com>
Subject: Re: PATCH: action stats double dip
Date: Fri, 25 Mar 2005 21:06:50 +0100	[thread overview]
Message-ID: <20050325200650.GC3086@postel.suug.ch> (raw)
In-Reply-To: <1111768884.1092.533.camel@jzny.localdomain>

* jamal <1111768884.1092.533.camel@jzny.localdomain> 2005-03-25 11:41
>  
> -	if (tcf_exts_dump_stats(skb, &f->exts, &route_ext_map) < 0)
> -		goto rtattr_failure;
> +	if (f->exts.action && f->exts.action->type == TCA_OLD_COMPAT)
> +		if (tcf_exts_dump_stats(skb, &f->exts, &route_ext_map) < 0)
> +			goto rtattr_failure;

Why is this needed? Maybe I'm missing something in the logic but
tcf_exts_dump_stats checks for exts->action and if in compat mode
provides the old stats TLVs. I'm not claiming that the current code
is correct but the fix should go into tcf_exts_dump_stats rather
than into every classifier.

  parent reply	other threads:[~2005-03-25 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25 16:25 PATCH: action stats double dip jamal
2005-03-25 16:41 ` jamal
2005-03-25 17:37   ` David S. Miller
2005-03-25 20:06   ` Thomas Graf [this message]
2005-03-25 20:25     ` jamal
2005-03-25 20:41       ` Thomas Graf
2005-03-25 21:39         ` jamal
2005-03-25 21:58           ` Thomas Graf
2005-03-25 23:06             ` jamal
2005-03-25 23:24               ` Thomas Graf
2005-03-25 23:59                 ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050325200650.GC3086@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.