From: Thomas Graf <tgraf@suug.ch>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, mikep@linuxtr.net
Subject: [PATCH 5/7] [ibmtr]: Use netif_carrier_* instead of IFF_RUNNING and remove obsolete usage of IFF_RUNNING
Date: Mon, 28 Mar 2005 02:09:31 +0200 [thread overview]
Message-ID: <20050328000931.GS3086@postel.suug.ch> (raw)
In-Reply-To: <20050328000610.GN3086@postel.suug.ch>
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/03/28 00:16:54+02:00 tgraf@suug.ch
# [ibmtr]: Use netif_carrier_* instead of IFF_RUNNING and remove obsolete usage of IFF_RUNNING
#
# Signed-off-by: Thomas Graf <tgraf@suug.ch>
#
# drivers/net/tokenring/ibmtr.c
# 2005/03/28 00:16:44+02:00 tgraf@suug.ch +3 -8
# [ibmtr]: Use netif_carrier_* instead of IFF_RUNNING and remove obsolete usage of IFF_RUNNING
#
diff -Nru a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenring/ibmtr.c
--- a/drivers/net/tokenring/ibmtr.c 2005-03-28 01:07:47 +02:00
+++ b/drivers/net/tokenring/ibmtr.c 2005-03-28 01:07:47 +02:00
@@ -888,11 +888,6 @@
ti->sap_status = CLOSED; /* CLOSED or OPEN */
ti->open_failure = NO; /* NO or YES */
ti->open_mode = MANUAL; /* MANUAL or AUTOMATIC */
- /* 12/2000 not typical Linux, but we can use RUNNING to let us know when
- the network has crapped out or cables are disconnected. Useful because
- the IFF_UP flag stays up the whole time, until ifconfig tr0 down.
- */
- dev->flags &= ~IFF_RUNNING;
ti->sram_phys &= ~1; /* to reverse what we do in tok_close */
/* init the spinlock */
@@ -1242,7 +1237,7 @@
ti->open_status = CLOSED;
ti->sap_status = CLOSED;
ti->open_mode = AUTOMATIC;
- dev->flags &= ~IFF_RUNNING;
+ netif_carrier_off(dev);
netif_stop_queue(dev);
ti->open_action = RESTART;
outb(0, dev->base_addr + ADAPTRESET);
@@ -1323,7 +1318,7 @@
break;
}
netif_wake_queue(dev);
- dev->flags |= IFF_RUNNING;/*BMS 12/2000*/
+ netif_carrier_on(dev);
break;
case DIR_INTERRUPT:
case DIR_MOD_OPEN_PARAMS:
@@ -1427,7 +1422,7 @@
ring_status);
if(ring_status& (REMOVE_RECV|AUTO_REMOVAL|LOBE_FAULT)){
netif_stop_queue(dev);
- dev->flags &= ~IFF_RUNNING;/*not typical Linux*/
+ netif_carrier_off(dev);
DPRINTK("Remove received, or Auto-removal error"
", or Lobe fault\n");
DPRINTK("We'll try to reopen the closed adapter"
next prev parent reply other threads:[~2005-03-28 0:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 0:06 [PATCHSET] IFF_RUNNING related fixes Thomas Graf
2005-03-28 0:06 ` [PATCH 1/7] [au1000]: Use netif_carrier_* instead of IFF_RUNNING Thomas Graf
2005-03-28 1:20 ` Thomas Graf
2005-03-31 1:22 ` Jeff Garzik
2005-03-28 0:07 ` [PATCH 2/7] [bmac]: Remove obsolete usage of IFF_RUNING Thomas Graf
2005-03-28 0:08 ` [PATCH 3/7] [tlan]: Use netif_carrier_* intead of IFF_RUNNING Thomas Graf
2005-03-28 0:08 ` [PATCH 4/7] [lmc]: Use netif_carrier_* instead " Thomas Graf
2005-03-28 0:09 ` Thomas Graf [this message]
2005-03-28 0:10 ` [PATCH 6/7] [sk98lin]: Use netif_carrier_* instead of IFF_RUNNING and remove obsolete usage " Thomas Graf
2005-03-28 0:10 ` [PATCH 7/7] [NET]: Change comment to describe the real meaning " Thomas Graf
2005-03-28 0:15 ` [PATCHSET] IFF_RUNNING related fixes Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328000931.GS3086@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=jgarzik@pobox.com \
--cc=mikep@linuxtr.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.