From: Sven Luther <sven.luther@wanadoo.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: ppc32 power3/4 pmac_cache.S build breakage fix.
Date: Mon, 28 Mar 2005 09:17:50 +0200 [thread overview]
Message-ID: <20050328071750.GA5735@pegasos> (raw)
In-Reply-To: <1111963487.5474.12.camel@gaston>
On Mon, Mar 28, 2005 at 08:44:47AM +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2005-03-27 at 14:37 +0200, Sven Luther wrote:
> > Hello,
> >
> > Find attached a trivial fix for the 32bit power3 and power4 introduced by
> > benh's latest round of pmac sleep fixes.
> >
> > I am not sure if this is the best way to solve this problem, but it fixes the
> > issue.
>
> Bah, fixe plustot dans le code ... ajout un #ifdef CONFIG_ALTIVEC autour
> du dssall (enfin, de la section entiere avec le BEGIN/END inclus) pour
> le moment, quoi que ici, le mieux est encore de dire a l'asm de pas
> moufter. En ce qui concerne pmac_sleep vs. pmac_cache, #ifdef aussi pour
> le moment.
Le truc, c'est que l'ensemble du code de pmac_cache, il ne devrait pas etre
compiler si on est pas CONFIG_6xx, car la fonction n'est jamais appelle depuis
pmac_sleep si on est pas CONFIG_6xx.
Je te laisse gerer cela pour upstream ?
Amicalement,
Sven Luther
prev parent reply other threads:[~2005-03-28 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 12:37 ppc32 power3/4 pmac_cache.S build breakage fix Sven Luther
2005-03-27 22:44 ` Benjamin Herrenschmidt
2005-03-28 7:17 ` Sven Luther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328071750.GA5735@pegasos \
--to=sven.luther@wanadoo.fr \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.