From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261546AbVC3GmV (ORCPT ); Wed, 30 Mar 2005 01:42:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261769AbVC3GmV (ORCPT ); Wed, 30 Mar 2005 01:42:21 -0500 Received: from verein.lst.de ([213.95.11.210]:939 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S261546AbVC3Glx (ORCPT ); Wed, 30 Mar 2005 01:41:53 -0500 Date: Wed, 30 Mar 2005 08:41:45 +0200 From: Christoph Hellwig To: Andrew Morton Cc: Christoph Hellwig , wendyx@us.ltcfwd.linux.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fixup newly added jsm driver Message-ID: <20050330064145.GA12571@lst.de> References: <20050329210735.GA5664@lst.de> <20050329134734.71c16b54.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050329134734.71c16b54.akpm@osdl.org> User-Agent: Mutt/1.3.28i X-Spam-Score: -4.901 () BAYES_00 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2005 at 01:47:34PM -0800, Andrew Morton wrote: > Christoph Hellwig wrote: > > > > One more prematurely added drivers.. > > This driver was first sent out for review a month ago, was upissued twice > and generated over seventy linux-kernel emails including some from Russell > and some from Greg. It was by no means a "premature" addition. > > One could say that it was inadequately reviewed, but how is one to > determine that? If the thing has been under discussion for a month and the > submitter says "I've addressed all comments" then it's going to get merged. I don't think the submitter should say all issues have been addressed but that should come from a sufficiently trusted reviewer.