From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Jones <davej@redhat.com>
Subject: [PATCH] incorrect memset usage.
Date: Thu, 31 Mar 2005 01:21:26 -0500
Message-ID: <20050331062126.GA30472@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

two patches, one for stable, one for unstable..
memset args are swapped..

		Dave


--- xen-2.0.bk/tools/libxutil/sys_net.c~	2005-03-31 01:11:27.852264603 -0500
+++ xen-2.0.bk/tools/libxutil/sys_net.c	2005-03-31 01:11:39.320054735 -0500
@@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
     static char buf[MAC_LENGTH + 1];
     int buf_n = sizeof(buf);
 
-    memset(buf, buf_n, 0);
+    memset(buf, 0, buf_n);
     snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
              mac[0], mac[1], mac[2],
              mac[3], mac[4], mac[5]);





--- xeno-unstable.bk/tools/libxutil/sys_net.c~	2005-03-31 01:18:50.981164430 -0500
+++ xeno-unstable.bk/tools/libxutil/sys_net.c	2005-03-31 01:19:00.901236556 -0500
@@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
     static char buf[MAC_LENGTH + 1];
     int buf_n = sizeof(buf);
 
-    memset(buf, buf_n, 0);
+    memset(buf, 0, buf_n);
     snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
              mac[0], mac[1], mac[2],
              mac[3], mac[4], mac[5]);
--- xeno-unstable.bk/tools/ioemu/iodev/harddrv.cc~	2005-03-31 01:19:11.627152192 -0500
+++ xeno-unstable.bk/tools/ioemu/iodev/harddrv.cc	2005-03-31 01:19:22.851971006 -0500
@@ -3666,7 +3666,7 @@ ssize_t sparse_image_t::read_page_fragme
    }
    else
    {
-     memset(buf, read_size, 0);
+     memset(buf, 0, read_size);
    }
  }
  else